Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): add the default group during the SecurityRule check #1816

Merged

Conversation

AlexisSouquiere
Copy link
Collaborator

@AlexisSouquiere AlexisSouquiere commented Jun 6, 2024

Fix #1786

Fix deprecated AuthenticationProvider in BasicAuthAuthenticationProvider

Tests performed:

  • No Authentication: uses the default-group
  • Basic auth + default-group: anonymous users can access with default-group (tested with patterns too)
  • Basic auth + default-group: logged users can access with the group associated to their user + default-group
  • Basic auth + no default-group: anonymous users are requested to login
  • Basic auth + no default-group: logged users can access with the group associated to their user + default-group

Tester the same with LDAP / Oauth2 / external claim instead of basic auth. Results are the same

@AlexisSouquiere AlexisSouquiere changed the title Add the default group during the SecurityRule check fix(auth): add the default group during the SecurityRule check Jun 6, 2024
@AlexisSouquiere AlexisSouquiere marked this pull request as ready for review June 7, 2024 10:17
@tchiotludo tchiotludo merged commit ef8e8f4 into tchiotludo:dev Jun 27, 2024
4 checks passed
@pkuhlu
Copy link

pkuhlu commented Jul 2, 2024

Thanks for the fix! When is it a good time to release a new version to include this fix? @tchiotludo
Waiting for the fix to use the new ACL system in 0.25.0

@tchiotludo
Copy link
Owner

@pkuhlu this week if everything goes well @AlexisSouquiere is validating the release now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Anonymous user has no role and always redirect to login page. [0.25.0]
3 participants