Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For now you are using empty array for ingress
paths
option as a defaultIn ingress helm template used
range
, so empty array by default renders as invalid k8s Ingress resource and to deploy this chart i have to specifypaths
. In most cases default path is/
Examples
Some examples of ingress values, most of them using
/
as default:Another approach is to use fallback for paths when empty, but it is overkill for charts is not overriding application path
That will is fixed
This fixes k8s validation error on helm install (Ansible used):
fatal: [node1]: FAILED! => {"changed": false, "command": "/usr/local/bin/helm --namespace=akhq --version=0.1.3 upgrade -i --reset-values -f=/tmp/tmpvs_giipm.yml akhq akhq/akhq", "msg": "Failure when executing Helm command. Exited 1.\nstdout: \nstderr: Error: UPGRADE FAILED: error validating \"\": error validating data: ValidationError(Ingress.spec.rules[0].http): missing required field \"paths\" in io.k8s.api.networking.v1beta1.HTTPIngressRuleValue\n", "stderr": "Error: UPGRADE FAILED: error validating \"\": error validating data: ValidationError(Ingress.spec.rules[0].http): missing required field \"paths\" in io.k8s.api.networking.v1beta1.HTTPIngressRuleValue\n", "stderr_lines": ["Error: UPGRADE FAILED: error validating \"\": error validating data: ValidationError(Ingress.spec.rules[0].http): missing required field \"paths\" in io.k8s.api.networking.v1beta1.HTTPIngressRuleValue"], "stdout": "", "stdout_lines": []}