Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New attribute to filter Connect Configs by regexp #477

Merged
merged 3 commits into from
Oct 30, 2020

Conversation

twobeeb
Copy link
Contributor

@twobeeb twobeeb commented Oct 26, 2020

I followed the same logic you implemented for topics.
It has the sames limitations as your implementation : it only makes sense when the user have Read-Only acces, because the filter is only verified on list and search.
It has the same vulnerability as your implementation : if the user have roles read/create/update/delete, he can create/update/delete connect configs that doesn't follow the regex.

I consider this OK because for our use cases, we use AKHQ as a Read Only support/monitoring tool.
I may be worth mentioning this behavior in the documentation.

@tchiotludo
Copy link
Owner

Seems to be fine !
Can you just add a unit test to validate it please ?
I will not use this feature myself, I would prefer to have a unit test to keep it in my mind.
Also we need to move this when doing #254, will have a unit to not forgot

Copy link
Owner

@tchiotludo tchiotludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment

@tchiotludo tchiotludo merged commit 4a7053b into tchiotludo:dev Oct 30, 2020
@tchiotludo
Copy link
Owner

Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants