Fix broken topic browsing when using config files without a 'schema-registry' section #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig files without a 'schema-registry' section present were used.
|
Hm - bunch of unit tests failed in the automatic build that passed for me locally. @tchiotludo have any of the tests been flaky lately or should I look into this more? |
|
Test are flakky on the connect part. I restart it 😁 |
Works perfectly 👍 Thanks for having a look at this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @xpr3sso discovered, my recent aada01e commit broke things if using an application config file that omitted the 'schema-registry' section entirely. This PR should fix that. (And also fixes an unrelated "toSchemasLastestVersion" -> "toSchemasLatestVersion" typo elsewhere that I happened to see.)
@xpr3sso - Please let me know if this works for you! Thanks for catching the bug!