Show size in bytes in the /topic page #616 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a function to show bytes size with a round way. With this commit now its possible se values likce 1.2567 GB Resolve tchiotludo#616
tchiotludo
requested changes
Jun 7, 2021
There was a problem hiding this comment.
Sorry for late reply, lot of works this times.
Just test the PR and I don't understand why 4 characters after dot ? why not just 3 ?
Maybe use a lib like : https://www.npmjs.com/package/pretty-bytes to display it ?
|
@tchiotludo i changed for 3 characters after dot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a function to show bytes size with a round way.
With this commit now its possible se values likce 1.2567 GB
Resolve #616