Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): allow setting container securityContext and use Chart.AppVersion as image tag #768

Merged
merged 1 commit into from
Jul 27, 2021
Merged

feat(helm): allow setting container securityContext and use Chart.AppVersion as image tag #768

merged 1 commit into from
Jul 27, 2021

Conversation

chgl
Copy link
Contributor

@chgl chgl commented Jul 22, 2021

This adds 2 changes to the helm chart:

  1. make the container security context configurable as well - besides the current PodSecurityContext
  2. uses the image tag corresponding to the Chart's AppVersion. This avoids using the discouraged use of the latest tag.

Thank you for your great work!

@chgl chgl changed the title container securityContext can be set and image tag is taken from AppVersion feat(helm): allow setting container securityContext and use Chart.AppVersion as image tag Jul 22, 2021
@tchiotludo tchiotludo merged commit 79d0f96 into tchiotludo:master Jul 27, 2021
@tchiotludo tchiotludo mentioned this pull request Jul 27, 2021
Closed
@chgl chgl deleted the made-container-security-context-configurable-and-use-appversion branch July 27, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chgl @tchiotludo