enhacement: prevent UI freezing with large messages and single messages downloading #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cluster with fewer pages [tchiotludo#835]
|
@tchiotludo what do you think about this approach? |
tchiotludo
requested changes
Jan 3, 2022
…nd delegate 'truncate message' to frontend
|
I made the changes @tchiotludo, let me know if there is something else to change |
tchiotludo
requested changes
Jan 4, 2022
… to 'truncated' property in Record class and added some docs
… to 'truncated' property in Record class and added some docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #564
Changes:
I added a const (maxKakfaMessageLength) to limit the size (1000000 bytes) of the messages of a topic when retrieving a list of all those, in order to prevent UI freezing.
In order to set the new value of the message, I added a setter method in the Record class.
I also added a function (filterMessageLength) that is called after filter records that will be responded as the request of the frontend where is checked if the limit of the message is exceeded and then is sliced in a short preview.
I added a new action to the Table component which calls the onDownload event, in order to allow download a message when previewing a single one. I also implemented the method which downloads a file with the message value as content (.json format).