Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link consumergroup topics offset to data single #995

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Link consumergroup topics offset to data single #995

merged 1 commit into from
Jan 26, 2022

Conversation

timtebeek
Copy link
Contributor

Fixes #992

Have very little experience with React & jsx , so this should be considered a rough first attempt.

Also was not yet able to verify locally, as the development server environment does not have any consumer groups by default; and I didn't yet find the time to create a topic & consumer. Might be nice to expand the development environment with the test data seen here.

@tchiotludo tchiotludo merged commit 22245a1 into tchiotludo:dev Jan 26, 2022
@tchiotludo
Copy link
Owner

It's work well :) nice first jsx 👍

@timtebeek timtebeek deleted the link-consumergroup-topics-offset branch January 26, 2022 21:26
@timtebeek
Copy link
Contributor Author

Awesome, thanks for checking and merging it so quickly!

@tchiotludo
Copy link
Owner

You have a lot of chance, I was blocking few hours this night on akhq 😅

@timtebeek
Copy link
Contributor Author

Tried it just now, and I'm wondering if we should link to offset-1 instead. 😅
Getting a few not-found responses, whereas the offset-1 record is present.

@tchiotludo
Copy link
Owner

You are true, we must even more don't go to single page also.
The better will be to go offset-1 on this partition and let the full page (will all the record).
You can know if there is a transaction (that led -1) or not (that to offset).
The better for the user is so to display a full page :)

@timtebeek
Copy link
Contributor Author

Something like this then? https://github.com/tchiotludo/akhq/compare/dev...timtebeek:link_to_offset-1?expand=1
Wasn't sure what is and is not allowed within the ${...} expressions.

@tchiotludo
Copy link
Owner

I don't remember for the ${...} but I think it's good
and the link must be :

<Link to={`/ui/${this.state.selectedCluster}/topic/${obj.name}/data?partition=${obj.partition}&after=${obj.partition}-${obj.offset - 1}`}>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link from consumer group topics offset column to topic message
2 participants