-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iOS and MacOS support #3
Conversation
Thanks for your contribution! I just have a question: is it possible to move the About your notes:
I wasn't actually sure this was still needed, this was just something I added at the beginning of the project and forgot to remove/look into.
No problems with that, everything should still work.
That's pretty strange because everything was working correctly in the CI. Maybe this is a MacOS specific issue? AGP was just kept at an older version because IntelliJ didn't support higher that that, but this seems to no longer be the case so that's not an issue anymore.
It was just a leftover of before 1.2.0, when the library didn't support Compose Resources and needed a different implementation for each platform.
There is no reason it wouldn't work since you haven't added any iOS/MacOS specific function. Every platform implementation except Android's uses Skiko as the backend, so as long as Skiko behaves the same on every platform everything should work.
Thanks!
No problem with that, that is completely understandable. I'll just add a warning to the README saying that the native targets aren't as tested as the others. |
Usually it's not done this way as it may break running the iOS app from AS, but I will try to move the dir there and see if it works. We can't get rid of the subdir because it's opened in Xcode
It's an issue with my setup - I use a java version that was not supported by your gradle / agp versions. My problem, but a dep update wouldn't hurt I thought. I can revert that but it will involve installing another Jdk instance
Yes, I was not sure how you do these kinds of things and did not want to impose my solutions (I usually create a singleton in buildSrc folder). Please set that up in any way you like and I will follow that example in the future.
I do not like the idea of logging something in production and in a library. If logging is necessary, introduce a callback or an interface users can implement. By hiding logging in the internal API, you do not let any user of the library override this behavior. I am sorry for being unclear, I did not suggest adding a library to prod executable, I assumed that logging was only needed for your debugging, so suggested to use that temporarily and remove the logging calls when publishing to prod (kermit allows to do that).
That was also my assumption, so I hope it's not a problem I removed it.
I agree, all should work fine, our team has already tested the fork in a prod-ready application and it passed qa with flying colors with the resolution of #2 especially. |
I moved the iOS app inside the /testapp. That indeed resulted in non-standard configuration, but I only had to change some xcode scripts for that to work, so it should be fine given that everyone uses provided run configuration I pushed. |
No it's all good, as I said AGP was outdated because of IntelliJ restrictions, but it seems they fixed it on the latest.
Most of the logging is just warnings addressed at the developers, for example when an icon doesn't exist, so it shouldn't happen in a prod build. I can remove the logging entirely if that's really bothering you.
Don't worry it's not, I would have done it sooner or later, it's just that it wasn't a priority since it's not part of the library itself.
Thanks for that! If it's all good for you, I'll merge this PR tomorrow, change some things and publish the new version. |
❌ published to remote - undocumented how to provide publishing credentials
❌ CI passes - unable to run CI from a fork without setting up the entire pipeline
Screenshot of iOS 17 device
Notes:
jvmToolchain
misconfiguration. The project doesn't need toolchains. I had to replace toolchains with explicit target spec to use my jdk 22 installation.