-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing properties on prefer-property-order
has unexpected behavour
#57
Comments
Hey @moshest what is the purpose of the rule if we ignore properties that aren’t in the list? We are already allowing properties in the list to be missing from the package.json file. |
Just ordering. Like the role The user should use other roles to require properties. |
Gotcha. I see what you are thinking now. Thanks for talking that through, @moshest! |
This change gives better recommendations for what change is required by the user to resolve the lint issue. It also no longer throws an error when a property exists in the package.json file that doesn't exist in the preferred property order array. Thanks @moshest for the input.
Hi @moshest v2.10.0 has been released! Let me know if it meets your needs. Thank you for suggesting the great improvements. |
Works great! |
My package.json has the property
nyc
which is not included on the default order list at:This rule is failing with the following error:
I think that
prefer-property-order
should ignore properties that are not in the preferred property list.The text was updated successfully, but these errors were encountered: