Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

feat: 新增 Anchor 锚点组件 #184

Merged
merged 30 commits into from
Dec 7, 2022
Merged

Conversation

wuxinheng
Copy link
Collaborator

@wuxinheng wuxinheng commented Dec 5, 2022

合并请求( Pull Request )

新增 Anchor

关于本次更新的主要内容

Anchor基本使用,包括一定js 动态效果

本次合并的类型是什么?

  • 缺陷修复(对缺陷的修复,包括紧急修复和一般修复)
  • 功能开发(新功能、特性的开发,之前功能的完善等)
  • 代码风格(包括命名规范、格式、优化代码的写法等)
  • 文档更新(仅对当前版本的文档进行增加、完善和更新)
  • 重构(没有新功能,仅对代码的重构、调整)
  • 测试(单元测试、集成测试、性能测试、压力测试等)
  • DevOps (CI/CD、git action 等)
  • 其他,请在下面进行描述:

    其他描述写在这里

关联的 ISSUE 编号

ISSUE 编号:#50

其他相关信息

非常感谢您对本项目的贡献,所有的合并请求最终将由作者通过才可以合并成功。并且要求贡献者需要谦虚地对待每一次评审的内容,并且尊重每一位贡献者的回复。良好的规范才能让项目健康的运转,保持利他精神才是我们一直信奉的价值观。

Copy link
Collaborator

@elvismile elvismile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.vscode 目录是不是应该加入到忽略目录列表? @AchievedOwner @wuxinheng

Copy link
Collaborator

@elvismile elvismile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tdesign-blazor.js里新增的js方法考虑用初始化的形式包一层js,因为有其他组件也在用这个js文件,可能会引起添加多余的事件给window对象。可以参照master分支上的写法

@wuxinheng wuxinheng requested a review from elvismile December 5, 2022 09:51
@wuxinheng wuxinheng requested a review from elvismile December 5, 2022 12:03
AnchorItem 使用ChildComponentAttribute
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

@teacher-zhou teacher-zhou linked an issue Dec 6, 2022 that may be closed by this pull request
@teacher-zhou teacher-zhou changed the title 【新增】Anchor 锚点组件 feat: 新增 Anchor 锚点组件 Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

@pull-request-quantifier-deprecated

This PR has 240 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +237 -3
Percentile : 64%

Total files changed: 7

Change summary by file extension:
.razor : +89 -1
.cs : +113 -0
.js : +35 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@teacher-zhou teacher-zhou added this to the 0.3 milestone Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

@teacher-zhou teacher-zhou merged commit 36f7b56 into master Dec 7, 2022
@teacher-zhou teacher-zhou deleted the feature/components/anchor branch December 7, 2022 06:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchor 锚点
3 participants