Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

fix: Message以及 Notification 无法定时关闭的bug #200

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

ChisterWu
Copy link
Collaborator

使用Timers.Timer 代替 Threading.Timer 在。net5及其他版本

本次提交包含什么范围

  • [fix]修复Message以及Notification组件无法关闭的bug
  • [feat]在Net6及以上版本使用PeriodicTimer 代替System.Threading.Timer,在.Net5及其他版本使用Systemm.Timers.Timer代替System.Threading.Timer.
  • [docs]文档 无
  • [pref]性能 新的定时器可以获得更高的性能
  • [refactor]重构无
  • [style]风格 无
  • [test]测试 无
  • [build]编译 无
  • [ci]集成 无
  • [others]其他,请说明:

关联的 ISSUE 编号

#164

使用Timers.Timer 代替 Threading.Timer 在。net5及其他版本
@pull-request-quantifier-deprecated

This PR has 20 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +16 -4
Percentile : 8%

Total files changed: 1

Change summary by file extension:
.cs : +16 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Unit Test Results

🟢  Tests Passed      |      ⏱️ 4s

📝 Total ✔️ Passed ❌ Failed ⚠️ Skipped
93 93 0 0

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

@teacher-zhou teacher-zhou self-requested a review December 7, 2022 10:30
@teacher-zhou teacher-zhou changed the title 修复 Message以及 Notification 无法定时关闭的bug fix: Message以及 Notification 无法定时关闭的bug Dec 7, 2022
Copy link
Collaborator

@teacher-zhou teacher-zhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice coding

@teacher-zhou teacher-zhou added this to the 0.3 milestone Dec 7, 2022
@teacher-zhou teacher-zhou added the bug 程序不能正常工作 label Dec 7, 2022
@teacher-zhou teacher-zhou merged commit 211ef05 into master Dec 7, 2022
@teacher-zhou teacher-zhou deleted the bugfix/notification_message_display/_error branch December 7, 2022 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 程序不能正常工作 Extra Small size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[缺陷] Notification 和 Message 组件无法自动关闭
2 participants