Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

feat: TTable 的自定义表底功能 #242

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

teacher-zhou
Copy link
Collaborator

本次提交包含什么范围

  • [fix]修复(对缺陷的修复)
  • [feat]功能(新功能、特性的开发)
  • [docs]文档(仅对当前版本的文档进行增加、完善和更新)
  • [pref]性能(改进性能的代码更改)
  • [refactor]重构(既不修复bug也不添加特性的代码更改)
  • [style]风格(不影响代码含义的更改(空白、格式化、缺少分号等)
  • [test]测试(添加缺失的测试或修改现有的测试)
  • [build]编译(影响构建系统或外部依赖的更改)
  • [ci]集成(对CI配置文件和脚本的更改)
  • [others]其他,请说明:

参考 https://www.conventionalcommits.org/zh-hans/v1.0.0/

关联的 ISSUE 编号(一行一个)

Closing #220

fix(TTable): 级联 TTable 时的 ChildComponents 参数判断
@pull-request-quantifier-deprecated

This PR has 563 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +359 -204
Percentile : 85.43%

Total files changed: 11

Change summary by file extension:
.sln : +0 -0
.cshtml : +1 -1
.xml : +102 -96
.razor : +144 -48
.cs : +112 -59

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@teacher-zhou teacher-zhou linked an issue Feb 28, 2023 that may be closed by this pull request
@teacher-zhou teacher-zhou added this to the 2023 Q1 milestone Feb 28, 2023
@github-actions github-actions bot added feature 提出新的需求和功能 minor labels Feb 28, 2023
@github-actions
Copy link

Unit Test Results

🟢  Tests Passed      |      ⏱️ 4.5s

📝 Total ✔️ Passed ❌ Failed ⚠️ Skipped
126 124 0 2

@github-actions
Copy link

@teacher-zhou teacher-zhou merged commit c251adc into master Feb 28, 2023
@teacher-zhou teacher-zhou deleted the feature/component/table_custom_footer branch February 28, 2023 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[组件]强化table:自定义表尾的表格
2 participants