Skip to content

Commit

Permalink
Fix bug in previous commit; fixes #438
Browse files Browse the repository at this point in the history
  • Loading branch information
tdewolff committed Sep 9, 2023
1 parent 6639ef2 commit 343ab6e
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 47 deletions.
21 changes: 21 additions & 0 deletions cmd/minify/fs.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package main

import (
"io/fs"
"os"
"path/filepath"
)

func NewFS() fs.FS {
return dirFS("")
}

type dirFS string

func (dir dirFS) Open(name string) (fs.File, error) {
return os.Open(filepath.Join(string(dir), name))
}

func (dir dirFS) Stat(name string) (fs.FileInfo, error) {
return os.Stat(filepath.Join(string(dir), name))
}
4 changes: 2 additions & 2 deletions cmd/minify/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ func run() int {
tasks = append(tasks, task)
roots = append(roots, "")
} else {
fsys := os.DirFS("").(fs.StatFS)
fsys := NewFS()
tasks, roots, err = createTasks(fsys, inputs, output)
if err != nil {
Error.Println(err)
Expand Down Expand Up @@ -565,7 +565,7 @@ func createTasks(fsys fs.FS, inputs []string, output string) ([]Task, []string,
tasks := []Task{}
roots := []string{}
for _, input := range inputs {
root := filepath.Clean(filepath.Dir(input)) // + string(os.PathSeparator) + ".")
root := filepath.Clean(filepath.Dir(input))
input = filepath.Clean(input)

var err error
Expand Down
60 changes: 15 additions & 45 deletions cmd/minify/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,55 +19,25 @@ func TestCreateTasks(t *testing.T) {
tasks map[string]string
}{
// root file
{"a.js", "", map[string]string{
"a.js": "a.js",
}},
{"a.js", ".", map[string]string{
"a.js": "a.js",
}},
{"a.js", "./", map[string]string{
"a.js": "a.js",
}},
{"a.js", "out", map[string]string{
"a.js": "out",
}},
{"a.js", "out/", map[string]string{
"a.js": "out/a.js",
}},
{"a.js", "", map[string]string{"a.js": "a.js"}},
{"a.js", ".", map[string]string{"a.js": "a.js"}},
{"a.js", "./", map[string]string{"a.js": "a.js"}},
{"a.js", "out", map[string]string{"a.js": "out"}},
{"a.js", "out/", map[string]string{"a.js": "out/a.js"}},

// nested file
{"dir/b.js", "", map[string]string{
"dir/b.js": "b.js",
}},
{"dir/b.js", ".", map[string]string{
"dir/b.js": "b.js",
}},
{"dir/b.js", "./", map[string]string{
"dir/b.js": "b.js",
}},
{"dir/b.js", "out", map[string]string{
"dir/b.js": "out",
}},
{"dir/b.js", "out/", map[string]string{
"dir/b.js": "out/b.js",
}},
{"dir/b.js", "", map[string]string{"dir/b.js": "b.js"}},
{"dir/b.js", ".", map[string]string{"dir/b.js": "b.js"}},
{"dir/b.js", "./", map[string]string{"dir/b.js": "b.js"}},
{"dir/b.js", "out", map[string]string{"dir/b.js": "out"}},
{"dir/b.js", "out/", map[string]string{"dir/b.js": "out/b.js"}},

// directory
{"dir", "", map[string]string{
"dir/b.js": "dir/b.js",
}},
{"dir", ".", map[string]string{
"dir/b.js": "dir/b.js",
}},
{"dir", "./", map[string]string{
"dir/b.js": "dir/b.js",
}},
{"dir", "out/", map[string]string{
"dir/b.js": "out/dir/b.js",
}},
{"dir/", "out/", map[string]string{
"dir/b.js": "out/b.js",
}},
{"dir", "", map[string]string{"dir/b.js": "dir/b.js"}},
{"dir", ".", map[string]string{"dir/b.js": "dir/b.js"}},
{"dir", "./", map[string]string{"dir/b.js": "dir/b.js"}},
{"dir", "out/", map[string]string{"dir/b.js": "out/dir/b.js"}},
{"dir/", "out/", map[string]string{"dir/b.js": "out/b.js"}},
}

recursive = true
Expand Down

0 comments on commit 343ab6e

Please sign in to comment.