Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target version for Python build #630

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

pydsigner
Copy link
Contributor

This endeavors to ensure we always have the latest go.mod to pull our Python version from. We could also do something with setuptools_scm to calculate Python version using the tags rather than looking at go.mod, but that runs the risk of getting out of sync.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #630 (d206994) into master (0474a31) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files          25       25           
  Lines        6773     6773           
=======================================
  Hits         5676     5676           
  Misses       1021     1021           
  Partials       76       76           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pydsigner
Copy link
Contributor Author

I believe this PR is ready now, everything new was working the first time except the Windows release, which is now fixed.

@pydsigner pydsigner changed the title Fix Go target for Python build Fix target version for Python build Oct 31, 2023
@tdewolff tdewolff merged commit 808d590 into tdewolff:master Oct 31, 2023
11 checks passed
@pydsigner pydsigner deleted the fix_python_workflow branch October 31, 2023 01:10
@tdewolff
Copy link
Owner

We might be forgetting to delete the old *.so? https://github.com/tdewolff/minify/actions/runs/6707735660/job/18228871370

@pydsigner
Copy link
Contributor Author

We might be forgetting to delete the old *.so? https://github.com/tdewolff/minify/actions/runs/6707735660/job/18228871370

Looks like the sdist is what's erroring again. This makes sense because I updated the sdist version by changing go.mod locally and committed, so it worked one time, but I forgot to add the go get to the sdist job so the version there gets stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants