JS AST: fix output of binding array with elision

tdewolff · Nov 20, 2023 · 687d71b · 687d71b
1 parent a879787
commit 687d71b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/js/ast.go b/js/ast.go
@@ -1194,6 +1194,8 @@ func (n BindingArray) String() string {
 			s += ","
 		}
 		s += " ...Binding(" + n.Rest.String() + ")"
+	} else if 0 < len(n.List) && n.List[len(n.List)-1].Binding == nil {
+		s += ","
 	}
 	return s + " ]"
 }
@@ -1203,16 +1205,23 @@ func (n BindingArray) JS(w io.Writer) {
 	w.Write([]byte("["))
 	for j, item := range n.List {
 		if j != 0 {
-			w.Write([]byte(", "))
+			w.Write([]byte(","))
+		}
+		if item.Binding != nil {
+			if j != 0 {
+				w.Write([]byte(" "))
+			}
+			item.JS(w)
 		}
-		item.JS(w)
 	}
 	if n.Rest != nil {
 		if len(n.List) != 0 {
 			w.Write([]byte(", "))
 		}
 		w.Write([]byte("..."))
 		n.Rest.JS(w)
+	} else if 0 < len(n.List) && n.List[len(n.List)-1].Binding == nil {
+		w.Write([]byte(","))
 	}
 	w.Write([]byte("]"))
 }

diff --git a/js/ast_test.go b/js/ast_test.go
@@ -118,6 +118,7 @@ func TestJS(t *testing.T) {
 		{"{};;", "{} ;"},
 		{"{}\n;", "{} ;"},
 		{"- - --3", "- - --3;"},
+		{"([,,])=>P", "([,,]) => { return P; };"},
 	}
 
 	re := regexp.MustCompile("\n *")