-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-AMENDMENT_MONTH_STANDARDIZED #128
Comments
I would suggest explicitly including roman numerals as month numbers as a conversion to be made by this amendment. |
Similarly to the AMENDMENT for DAY (#127) this was not in our original suite of tests, and like Paul, I question their value as CORE. I know some good arguments were put forward in Gainesville where some easy one may be corrected (as in example), but we excluded a number of other tests on Day and Month as we didn't regard those fields as CORE (other than helping to populate eventDate. I can see arguments for keeping YEAR as I know a lot of people use this on its own, but DAY and MONTH less so. I agree with @chicoreus - move to SUPPLEMENTAL |
I agree with SUPPLEMENTAL for the same reasons as for dwc:day |
In the light of recent comments, I have this to Notes, but feel free to edit: "We make the assumption that interpretable Roman numerals in dwc:month are valid as some data sources support this. In these cases, the result will be AMENDED numeric equivalents." |
@Tasilee Great. I've rephrased as: "Implementations should interpret strings interpretable Roman numerals in the range I-XII in dwc:month as integer month of the year values, as some natural science domains use roman numeral months to avoid language and d/m vs m/d order issues, and this information could be mapped into dwc:month (which, by definition, should only contain integers in the range 1-12). In these cases, the result will be AMENDED numeric equivalents" |
…sts to current specifications. DESCRIPTION: Updating implementation and fixing unit tests for AMENDMENT_MONTH_STANDARDIZED and AMENDMENT_DAY_STANDARDIZED to conform with current (2022-03-10) specification. Fixing return of Response.result from amendments to a empty map instead of null for easier handling by consumers of the method responses.
…t specifications. DESCRIPTION: Fixing error in unit tests and in implementation of AMENDMENT_MONTH_STANDARDIZED current specification is limited to intepreted as integer, and expectation in the validation data is that month names are not interpretable as such, removing translation of month names, and looking for integers in strings or strings that can explicitly be interpreted as an integer one to 12, including roman numerals for months.
…t current (2023-06-04) test descriptions. Adding ProvidesVersion annotations. Removing now empty file stubs for checked methods. Addressed tdwg/bdq#127 AMENDMENT_DAY_STANDARDIZED and tdwg/bdq#128 AMENDMENT_MONTH_STANDARDIZED. Removing deprecated wrapper methods.
I have edited the Notes to "Implementations should translate interpretable Roman numerals in the range I-XII in dwc:month as integer month values 1-12, as some natural science domains use roman numeral months to avoid language and day/month vs moth/day order. In these cases, the result will be AMENDED numeric equivalents." |
Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated" |
@Tasilee pointed to the GBIF API in #126, i.e. https://api.gbif.org/v1/vocabularies/Month/concepts/September/ This isn't adequate here (yet), as (1) the GBIF API does not provide the integer values 1-12 for a given month, (2) The GBIF API doesn't include roman numeral months as alternatives, and (3), the GBIF API currently only provides a small number of alternative languages for month names, and does not currently provide abbreviations. If (1) were addressed, it would provide a potential resource for implementors to consult, though currently more limited than some internationalized time libraries. |
The text was updated successfully, but these errors were encountered: