Remove taxonIDReference, relax requirements for taxonID #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make it optional - Move it after scientificName (which is required) - Mention authoritative checklist - Use Checklistbank URL as example - Update example dataset
I did not update the definition of scientificName to include "Foreign key to `package.taxonomic.scientificName`, since that could be confusing. The best place to indicate the relationship between observations.scientificName and package.taxonomic is in package.taxonomic, where it is already mentioned "based on the unique `observations.scientificName`"
kbubnicki
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #356
Remove
taxonomic.taxonIDReference, since it is better to include this info as part of thetaxonID.Remove
observations.taxonIDNote: I did not update the definition of scientificName to include:
Since that could be confusing. The best place to indicate the relationship between
observations.scientificNameandpackage.taxonomicis inpackage.taxonomic, where it is already mentioned:Update
taxonomic.taxonID:Make it optional => taxonomic scope can be created from data
Move it after
scientificName(which is required)Suggest as part of the definition:
Use Checklistbank URL as example
Update example dataset to reflect these changes