Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this work hot loading CSS changes? #2

Closed
praveenpuglia opened this issue Mar 27, 2018 · 4 comments
Closed

Does this work hot loading CSS changes? #2

praveenpuglia opened this issue Mar 27, 2018 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@praveenpuglia
Copy link

I have not really tried it but I was trying to build something with egoist/poi and bili today to share a component I built via npm but, the CSS part of the SFC wouldn't update upon build while running in watch mode.

Here's more on this - https://twitter.com/_egoistlily/status/978612899785486339

Wondering if this would fix that problem since it also uses rollup.

@mgdodge
Copy link
Collaborator

mgdodge commented Mar 27, 2018

I have not used this for hot reloading. I use the vue cli for the actual development, with its hot reloading capabilities. This is really more of a last-step sort of thing, preparing the SFC for distribution. My intent here is to keep this code as simple as possible, and strictly for packaging.

My personal use case for this actually uses scoped CSS, which is inlined into the js files instead of separated out. I can, however, see a use for extracting the CSS into a separate file. I will look into it, but if you manage to figure it out first, feel free to submit a PR!

@mgdodge mgdodge added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 1, 2018
mgdodge pushed a commit that referenced this issue Oct 3, 2018
…tes to develop

* commit 'ac05a36be811de97fc5a1f69525949c3e0231936':
  Swap buble back for babel
  Rename some files for clarity, named exports of library components
@mgdodge
Copy link
Collaborator

mgdodge commented Oct 5, 2018

Github is in error, that commit had nothing to do with this issue. The commit message is from another remote for this repo.

@mgdodge
Copy link
Collaborator

mgdodge commented May 17, 2019

@praveenpuglia is this still an issue/request? rollup and all related plugins have been updated numerous times since this issue was created. Just released v2.0.0 of this utility today, cleaning house a bit, thought I'd reach out. I'll probably end up closing this issue since the vue cli is the officially recommended way of getting a hot-reloading dev experience.

@praveenpuglia
Copy link
Author

I agree.
Glad that you reached out after so long. Thanks so much :)

mgdodge pushed a commit that referenced this issue Feb 2, 2021
Vue 3 Mode (beta/testing)

Approved-by: Reed Remington
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants