-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved output for the tag
command
#1627
Comments
This looks great! Are the components under
|
A component can't be both
In cases where Still not sure how to explain this using a short enough sentence to fit a terminal output :( |
While I think I understand the auto-tag behaviour, I'm not sure I understand the output. Would it be possible to see an example of the terminal output with component names rather than place-holders? |
Gotcha. Here's a complete flow with the updated outputs for $ bit init
successfully initialized a bit workspace.
$ touch foo.js
$ echo "require('./foo.js');" > bar.js
$ bit add foo.js --id foo
tracking component foo:
added foo.js
$ bit add bar.js --id bar
tracking component bar:
added bar.js
$ bit tag --all
2 component(s) tagged
(use "bit export [collection]" to push these components to a remote")
(use "bit untag" to unstage versions)
new components
(first version for components)
> foo@0.0.1
> bar@0.0.1 Now we have 2 new components $ echo "modification" > foo.js
$ bit tag foo # we can also use --all in this case, as 'bar' is not modified
2 component(s) tagged
(use "bit export [collection]" to push these components to a remote")
(use "bit untag" to unstage versions)
changed components
(first version for components)
> foo@0.0.2
auto-tagged components
(version bumps due to new versions for local component dependencies)
> bar@0.0.2
updated dependencies: foo@0.0.2 |
Thanks for the detailed example! What do you think about something like this?
|
I like the idea of connecting the explicitly tagged components with the ones that are implicitly tagged alongside them. @GiladShoham @davidfirst what say you? |
I don't have a decided opinion, both look good for me. |
I like them both, but the last one @imsnif mentioned is more elegant IMO. |
Completed. Merged. |
The current output of
bit tag
does not do a good job in explaining what was updated. Additionally, it fails to properly explain the differences betweenadded
,changed
orauto-tagged
.$ bit tag -a 2 component(s) tagged | 0 added, 1 changed, 1 auto-tagged changed components: [remote]/[namespace]/[name]@[version] auto-tagged components (as a result of tagging their dependencies): [remote]/[namespace]/[name]@[version]
Suggested output:
bit status
.export
oruntag
).auto-tagged
list the updated dependencies that triggeredauto-tag
.The text was updated successfully, but these errors were encountered: