Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace configuration's overrides should include imported components #1867

Closed
itaymendel opened this issue Jul 28, 2019 · 1 comment
Closed

Comments

@itaymendel
Copy link
Contributor

Description

When using the overrides feature in a project, the rules defined in it must apply to imported components as well.

Describe the solution you'd like

All override rules from the workspace should apply to imported components that fit the glob-pattern (or specific ID). Additionally, Bit should keep supporting the merge strategy for the override rules when taking to account the rule defined for the imported component (which should act as an override rule for a specific-ID in the workspace config).

Additional context

This feature should only be released when #1863 is ready.

@davidfirst
Copy link
Member

Completed. Added tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants