Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support react fragments #2072

Closed
elstr opened this issue Oct 16, 2019 · 1 comment · Fixed by #2073
Closed

Support react fragments #2072

elstr opened this issue Oct 16, 2019 · 1 comment · Fixed by #2073
Assignees
@davidfirst
Labels
type/feature

Comments

@elstr
Copy link

elstr commented Oct 16, 2019 •
edited
Loading

Description

When using react fragments as <> </> and running bit status you get an Unexpected token error.
After changing all fragments to div tags the error is solved.
I'm using bit version 14.4.1

Describe the solution you'd like

Would be useful to be able to use the latest react features 😃
@davidfirst davidfirst self-assigned this Oct 16, 2019
davidfirst added a commit to teambit/bit-javascript that referenced this issue Oct 16, 2019
@davidfirst
fix teambit/bit/issues/2072, upgrade module-definition package to sup…
477cd8e 
…port React fragments
@davidfirst davidfirst mentioned this issue Oct 16, 2019
Merged
@davidfirst davidfirst reopened this Oct 17, 2019
@davidfirst
Copy link
Member

It happened due to an old version of the module-definition package required by bit-javascript. This package required babel@6.x, which doesn't support React fragments.
Fixed by updating that package and many more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidfirst davidfirst

Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade bit-javascript to support React fragments teambit/bit
2 participants
@davidfirst @elstr