Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bit unable to add a dependency to component using overrides #2175

Closed
itaymendel opened this issue Dec 5, 2019 · 1 comment · Fixed by #2177
Closed

bit unable to add a dependency to component using overrides #2175

itaymendel opened this issue Dec 5, 2019 · 1 comment · Fixed by #2177
Assignees
@GiladShoham
Labels
area/dependencies priority/critical type/bug

Comments

@itaymendel
Copy link
Contributor

Describe the bug

While trying to reproduce a bug I encountered an issue where I use overrides to add a dependency to a component and Bit fails to do so and prints this error on each interaction:

unable to manually add the dependency "react" into "button".
it's not an existing component, nor existing package

Steps to Reproduce

  1. clone this repo
  2. run bit init
  3. run bit status

Expected Behavior

The dependencies set in the overrides's * section to button.

Specifications

  • Bit version: 14.6.0
  • Node version: 11.10.0
  • npm / yarn version: 6.7.0
  • Platform: macos mojave

Additional context

encountered this issue while trying to reproduce another... so this kindda blocking me from figuring out an issue with propagate.
@GiladShoham
Copy link
Member

This happens when using "+" to add a dependency but this package doesn't exist in the package.json so bit can't resolve the version to add.

GiladShoham added a commit that referenced this issue Dec 5, 2019
@GiladShoham
fixes #2175 - show missing packages from overrides configuration
02300ad
@GiladShoham GiladShoham mentioned this issue Dec 5, 2019
Merged
GiladShoham added a commit that referenced this issue Dec 8, 2019
@GiladShoham
Merge branch 'master' of https://github.com/teambit/bit into bug/#2175-…
d11bc6c 
…missing-overrdies-packages

# Conflicts:
#	CHANGELOG.md
GiladShoham added a commit that referenced this issue Dec 8, 2019
@GiladShoham
fixes #2175 - show missing packages from overrides configuration (#2177)
0e59488 
* fixes #2175 - show missing packages from overrides configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GiladShoham GiladShoham

Labels
area/dependencies priority/critical type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #2175 - show missing packages from overrides configuration teambit/bit
2 participants
@GiladShoham @itaymendel