Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error "Cannot read property 'scope' of undefined" #2308

Closed
davidfirst opened this issue Feb 6, 2020 · 1 comment
Closed

Error "Cannot read property 'scope' of undefined" #2308

davidfirst opened this issue Feb 6, 2020 · 1 comment
Labels
priority/critical type/bug

Comments

@davidfirst
Copy link
Member

Describe the bug

Happens when running bit export with no ids and it exports to multiple components.

Steps to Reproduce

  1. creates two components, export each one to a different collection.
  2. edit one of the components and require another component from a different collection (not from the two above).
  3. tag and run "bit export".

Expected Behavior

Should export successfully.

Screenshots, exceptions and logs

If applicable, add screenshots, exceptions, and logs to help explain your problem.

Specifications

  • Bit version: 14.7.3
  • Node version:
  • npm / yarn version:
  • Platform:
  • Bit compiler (include version):
  • Bit tester (include version):

Additional context

This is related to another bug: #2211, which happened previously, before 14.7.3.
The same bug now throws the error above.
davidfirst added a commit that referenced this issue Feb 6, 2020
@davidfirst
fix #2211 and #2308, when exporting to multiple scopes, make sure to …
174e408 
…not export their dependencies when these dependencies themselves are not export pending
@davidfirst davidfirst mentioned this issue Feb 6, 2020
Merged
davidfirst added a commit that referenced this issue Feb 6, 2020
@davidfirst
fix #2211 and #2308, when exporting to multiple scopes, make sure to …
e3cce86 
…not export their dependencies when these dependencies themselves are not export pending (#2309)
@davidfirst
Copy link
Member Author

Fixed by the PR above.

GiladShoham added a commit that referenced this issue Feb 9, 2020
@GiladShoham @davidfirst
Harmony/merge master (#2314)
c0ff1e3 
* fix #2211 and #2308, when exporting to multiple scopes, make sure to not export their dependencies when these dependencies themselves are not export pending (#2309)

* resolve #2268, prevent logger from holding the terminal once a command is completed by adding an error handler. Also, changed some "logger.debug" to "logger.silly". Also, support configuring the logger level by running "bit config set log_level <level>". Also, limit the number of concurrent files write to 100 (#2310)

* fix typo in the BitId README

* fix "bit status" and "bit tag" when new components require each other by module paths (#2313)

Co-authored-by: David First <david@bit.dev>
davidfirst added a commit that referenced this issue Feb 17, 2020
@davidfirst @arebokert
fix conflicts after merging master to harmony/main (#2358)
a53e20c 
* fix #2211 and #2308, when exporting to multiple scopes, make sure to not export their dependencies when these dependencies themselves are not export pending (#2309)

* bump dev version

* resolve #2268, prevent logger from holding the terminal once a command is completed by adding an error handler. Also, changed some "logger.debug" to "logger.silly". Also, support configuring the logger level by running "bit config set log_level <level>". Also, limit the number of concurrent files write to 100 (#2310)

* fix typo in the BitId README

* fix "bit status" and "bit tag" when new components require each other by module paths (#2313)

* Fix e2e-tests to avoid code execution inside "describe" blocks (#2329)

* move all Helper instantiation from describe to before.
* fix defaultScope tests, remove code that was entered by mistake in the describe block to before block.
* delete javascript-hook.e2e file, the tests there were written long ago, marked as "skip" and not relevant anymore.

* support import/require statements of module paths when it has no scope-name (e.g. "@bit/button") (#2331)

* resolve part of #2341, enable "--all" flag when "--all-versions" is used and vice versa, to enable re-exporting a component after deleting it (#2345)

* Fixed broken link leading to quick start guide (#2338)

* fix dynamic dist reference from package.json (#1808) when isolating via capsule (#2348)

* remove .only from extension tests

Co-authored-by: Erik <arebokert@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/critical type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidfirst