Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension loading process #2455

Closed
4 of 11 tasks
Tracked by #2280
GiladShoham opened this issue Mar 16, 2020 · 1 comment
Closed
4 of 11 tasks
Tracked by #2280

extension loading process #2455

GiladShoham opened this issue Mar 16, 2020 · 1 comment

Comments

@GiladShoham
Copy link
Member

GiladShoham commented Mar 16, 2020

This issue is a task list for many tasks required for proper extensions loading.

This is related to some of the tasks in issue: #2456

checklist

below you can find more details for some of the tasks

implementation

  • Move workspace extensions loading to be part of workspace extension instead of bit extensions
  • Load workspace extension according to workspace config
  • Load component extensions during component loading
    • during loading from workspace / fs
    • during loading from scope
  • load extension recursively (if extension added another extension)
  • import missing extensions of a component when importing the component
  • import missing extensions when check out a version of the component
  • import extensions if they are missing during loading (workspace or components)
  • load extension from scope even if they doesn't exist in the workspace

tests

  • make sure all old tests are pass

details

  • when importing missing extensions they should just be imported to the scope not to the workspace
  • load extension recursively - when loading recursively make sure:
    • we load the added config from nested extensions
    • we store dependencies (include extension as dependencies) from nested extensions in models
@GiladShoham GiladShoham added this to the harmony release v1.0 milestone Apr 1, 2020
@GiladShoham GiladShoham self-assigned this Apr 2, 2020
@qballer qballer added the harmony label Apr 5, 2020
@ranm8 ranm8 changed the title extensions loading process extension loading process Apr 7, 2020
GiladShoham added a commit that referenced this issue Apr 7, 2020
- load extensions added by another extension recursively
- related to #2455
- related to #2456
- related to #2280
@itaymendel
Copy link
Contributor

irrelevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants