Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding/adding package.json props of a component #1890

Merged
merged 6 commits into from
Aug 2, 2019

Conversation

davidfirst
Copy link
Member

@davidfirst davidfirst commented Aug 1, 2019

By using the overrides feature. (overrides key of bit.json file or bit.overrides of a package.json file).

Also, validate values entered by a user against npm specs.

Implements #1865


This change is Reviewable

@AppVeyorBot
Copy link

Build bit 1.0.7652 failed (commit d6358edd33 by @davidfirst)

@AppVeyorBot
Copy link

Build bit 1.0.7653 failed (commit 1cd3c06faa by @davidfirst)

@AppVeyorBot
Copy link

Build bit 1.0.7654 failed (commit 91ab4d5d2c by @davidfirst)

@AppVeyorBot
Copy link

Build bit 1.0.7655 completed (commit c7a9b483ae by @davidfirst)

@AppVeyorBot
Copy link

Build bit 1.0.7656 completed (commit 8e4ab65c29 by @davidfirst)

@davidfirst davidfirst merged commit 80b38bf into master Aug 2, 2019
@davidfirst davidfirst deleted the feature/override-pkg-json-props branch August 2, 2019 23:27
@davidfirst davidfirst changed the title implements #1865, allow overriding package.json props of a component … Allow overriding/adding package.json props of a component Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants