Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bit import when one module resolution alias is a directory of another alias #2016

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Fix bit import when one module resolution alias is a directory of another alias #2016

merged 2 commits into from
Sep 20, 2019

Conversation

davidfirst
Copy link
Member

@davidfirst davidfirst commented Sep 20, 2019 •
edited by GiladShoham
Loading

By adding a suffix of index.js when needed.

Fixes #2013

This change is Reviewable

@AppVeyorBot
Copy link

❌ Build bit 1.0.7971 failed (commit bd1cee1f79 by @davidfirst)

@AppVeyorBot
Copy link

✅ Build bit 1.0.7973 completed (commit b505c4f521 by @davidfirst)

@davidfirst davidfirst merged commit 9a895a5 into master Sep 20, 2019
@davidfirst davidfirst deleted the bug/alias-parent branch September 22, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bit import fails when one module resolution alias is a directory of another alias
2 participants
@davidfirst @AppVeyorBot