Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmony/help improvements #2604

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Harmony/help improvements #2604

merged 4 commits into from
Apr 21, 2020

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Apr 20, 2020 •
edited
Loading

Proposed Changes

  • change commands default group to ungrouped
  • pass private prop from legacy commands to paper extension
  • take command description from the description if shortDescription not defined
  • take group description from group name if not defined
  • related to Harmony - a new extension system engine #2280

This change is Reviewable

@GiladShoham GiladShoham mentioned this pull request Apr 20, 2020
Closed
60 tasks
@AppVeyorBot
Copy link

❌ Build bit 1.0.10066 failed (commit eaaa054a88 by @GiladShoham)

@AppVeyorBot
Copy link

❌ Build bit 1.0.10078 failed (commit 0ef6fdf065 by @davidfirst)

@GiladShoham GiladShoham merged commit 486b3ed into harmony/main Apr 21, 2020
@GiladShoham GiladShoham deleted the harmony/help-improvements branch April 21, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GiladShoham @AppVeyorBot @davidfirst