Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aspects): return an empty object from a plugin auto generated provider #7095

Merged
merged 1 commit into from
Feb 27, 2023
Merged

fix(aspects): return an empty object from a plugin auto generated provider #7095

merged 1 commit into from
Feb 27, 2023

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Feb 27, 2023 •
edited
Loading

Proposed Changes

  • This prevents harmony from throwing an error when trying to harmony.get(pluginComponentId)
  • This will fix an issue with forking a component that uses the new env format (env plugin with .bit-env. file)

@GiladShoham GiladShoham changed the title return an empty object from a plugin auto generated provider fix(aspects): return an empty object from a plugin auto generated provider Feb 27, 2023
@GiladShoham GiladShoham merged commit 1a7d580 into master Feb 27, 2023
@GiladShoham GiladShoham deleted the harmony-plugins-instances branch February 27, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guysaar223 guysaar223 guysaar223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiladShoham @guysaar223