Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Compare): Compare UI Fixes #7102

Merged
merged 7 commits into from
Mar 2, 2023
Merged

fix(Compare): Compare UI Fixes #7102

merged 7 commits into from
Mar 2, 2023

Conversation

luvkapur
Copy link
Member

@luvkapur luvkapur commented Feb 28, 2023 •
edited
Loading

  • Allow viewing component diffs with no change.
    • Remove Blank state when viewing the same comp ids in source and target
  • Pass ComponentDescriptor information for base and compare ids to the ComponentCompareContext
  • Switch source and target ids in ComponentCompareDrawerName
  • Prevent history from firing when scrolling horizontally in CodeCompare
  • Switch to inline view in CodeCompare for Components with no changes

@luvkapur luvkapur requested a review from odedre February 28, 2023 19:17
@luvkapur luvkapur changed the title Compare: add comp descriptor to model + allow viewing diffs with no changes fix(Compare): Compare UI Fixes Mar 1, 2023
@luvkapur luvkapur enabled auto-merge (squash) March 2, 2023 15:38
@luvkapur luvkapur merged commit 8cca1b0 into master Mar 2, 2023
@luvkapur luvkapur deleted the compare-fixes branch March 2, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odedre odedre odedre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luvkapur @odedre