fix, fix error "exists in flattenedEdges but not in flattened" #7107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t load the current component a a snap while it has a tag
… into current-flatten-as-tag
GiladShoham
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when it load the current component as a snap while it has a tag.
This is happening when a previous merge was done from
maininto the current lane, and this component shown in the error message, was not changed on the lane, so then the version was just "moved" from main to the lane without any extra snap.Because on a lane the components are always loaded by their snaps, this component was loaded by the snap although it has a tag pointing to the same snap. From here, the graph got an error trying to find it by a tag instead of the hash/snap.