Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link dependencies before installation #7145

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Link dependencies before installation #7145

merged 3 commits into from
Mar 20, 2023

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Mar 13, 2023 •
edited
Loading

Proposed Changes

  • core aspects, legacy, harmony, and local deps from the capsule are linked before installation.
  • the information about all the links is passed to the package manager, so that the package manager won't remove them.

@zkochan zkochan force-pushed the refactor-linking branch 8 times, most recently from 6267cd5 to d263629 Compare March 19, 2023 16:48
@zkochan zkochan marked this pull request as ready for review March 19, 2023 16:48
@zkochan zkochan requested a review from GiladShoham March 20, 2023 15:42
@GiladShoham GiladShoham merged commit b2434f5 into master Mar 20, 2023
@GiladShoham GiladShoham deleted the refactor-linking branch March 20, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkochan @GiladShoham