feature (workspace IDE config files) - new commands to write/delete config files in the workspace #7171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiladShoham
changed the title
guysaar223
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is still an EXPERIMENTAL feature!!!
This PR adds a new aspect (
workspace-config-files) to write/delete config files to/from the workspae.This is useful mostly for IDE support.
This aspect can write config files such as tsconfig.json, eslint config and prettier configs.
The aspect knows to calculate the correct config file for each component based on its env.
Then dedup the written config files to write as less as possible config files.
The aspect support registering new config writers by custom aspects in case you want to write more config files.
The aspect will write the real config files into
node_modules/.cachedirectory then it will write extending config files in the workspace / component folders (files that pointing to the real config files).At the moment this command might override your own config files in case you have such.
So please make sure to run with
--dry-runbefore running the actual command.An example output can be seen here:
https://app.warp.dev/block/rikUfU0Vw0eXvJmJG1aqjX