New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements(urls) - calculate preview url based on server host and basePath #7326

Merged

GiladShoham merged 4 commits into master from preview-url-proxy

Apr 27, 2023

Member

GiladShoham commented Apr 27, 2023 •

edited

Loading

Proposed Changes

calculate preview url based on host and basePath if provided
add host: String basePath: String to ComponentServer GraphqlSchema
add host: String basePath: String to the component model

GiladShoham added 4 commits

April 27, 2023 12:08


          improvements(urls) - calculate preview url based on server host and b…

1ac8e36

…asePath


          make server optional

2b5d642


          add host and basePath to component.server graphql schema

89fd3cb


          prefer server.host over server.url when calculating component preview…

5a19ceb

… url

guysaar223 approved these changes

View reviewed changes

GiladShoham merged commit 0237de0 into master

GiladShoham deleted the preview-url-proxy branch

April 27, 2023 14:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet