-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: symlink core aspects from a symlink that points to the current Bit CLI #7696
Merged
Merged
Changes from 63 commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
49a6348
feat: symlink core aspects from a symlink that points to the current …
zkochan ecb0372
link legacy and harmony
zkochan fe90d91
style: fix
zkochan 4870b3f
update bvm.path
zkochan c2855b9
fix(new/starters), sort the components to fork to create envs first (…
davidfirst f0bc398
fix(lane-merge-abort), restore components deleted by the last lane-me…
davidfirst 09d6be7
bump @teambit/legacy version to 1.0.528 [skip ci]
853589f
bump teambit version to 0.2.10 [skip ci]
343a951
API(scope) - expose new getIsolateAspectsOpts API from scope main run…
GiladShoham 441c000
bump teambit version to 0.2.11 [skip ci]
7fe63fc
fix(snap), fetch components from their lane during populateFlattenedD…
davidfirst 645a9e1
fix(refactoring): handle member transformations (#7701)
luvkapur 77b4a8b
feat: make progress throttle configurable (#7703)
zkochan c78ecae
fix(aspect-merger | merging): make sure consumer reference is not sta…
luvkapur b008f9f
bump @teambit/legacy version to 1.0.529 [skip ci]
a956a6a
fix(snap), prevent snapping when dependencies are from another lane (…
davidfirst f9d1ea4
bump @teambit/legacy version to 1.0.530 [skip ci]
eebf9f8
bump teambit version to 0.2.12 [skip ci]
4e52c7c
fix(bit new) - compile components again once all envs and their depen…
GiladShoham 6100399
fix(apps) - pass deploy context correctly from build app to deploy ap…
GiladShoham c4fc7ff
remove ComponentStatus.nested, it is not relevant in Harmony (#7630)
davidfirst 3f9dee0
fix(watch), fix high CPU by removing "useFsEvents: false" from chokid…
davidfirst 3699164
bump @teambit/legacy version to 1.0.531 [skip ci]
7128b3a
bump teambit version to 0.2.13 [skip ci]
b16b80f
add(webpack): watch options polling (#7708)
leimonio 87f6c0a
bump teambit version to 0.2.14 [skip ci]
5139111
bump teambit version to 0.2.14 [skip ci]
257412e
fix: update pnpm to fix auth issue in artifactory (#7714)
zkochan 835f0b2
fix: add missing dependencies to package.json (#7716)
zkochan de7ced3
types(envs) - expose more envs types (#7715)
GiladShoham cbfb0fa
fix: don't try to relink components in bit roots (#7665)
zkochan 398b705
bump @teambit/legacy version to 1.0.532 [skip ci]
20a56f3
bump teambit version to 0.2.15 [skip ci]
8d21828
improvement(ws-config) - re-enable auto writing workspace config duri…
GiladShoham 9ad5a9a
fix(generator) - cleanup envs / aspect loading errors during bit new …
GiladShoham 43e26eb
fix(refactoring): source file formatting after transform (#7720)
luvkapur 6d9d42b
fix: peer dependencies should be deduped when root components are use…
zkochan d3efeba
chore(deps) - remove browserslist (#7721)
GiladShoham 853861a
chore(isolator) - replace fs.remove with rimraf when clean capsules o…
GiladShoham 48b7c59
bump teambit version to 0.2.16 [skip ci]
e9e42c6
refactor, replace importManyIfMissingWithoutDeps call with importWith…
davidfirst 886daba
fix(remove), fix soft-removing a component after recovering it (#7724)
davidfirst 44a4395
bump teambit version to 0.2.17 [skip ci]
c4e93f5
Aspect cache config (#7725)
ranm8 7511c8a
bump teambit version to 0.2.18 [skip ci]
a2984c5
fix(typescript): import alias and function type reference transform (…
luvkapur 379465e
fix(switch), ensure components from other lanes are unavailable (#7706)
davidfirst 678ea08
improve an error when snapping/tagging a dependency from another lane…
davidfirst 920be09
fix(env-get), remove wrong pipelines data, instead refer to using "bi…
davidfirst 98c238c
add onLanesOnly when snapping on a lane (#7730)
davidfirst 1f86be9
remove isAvailableOnCurrentLane if is true before writing to the .bit…
davidfirst 9984920
fix(code-compare): code compare navigation loading styles (#7732)
luvkapur a58be69
fix(scope-rename), rename scope of envs in .bitmap config (#7733)
davidfirst 2a3d01b
bump @teambit/legacy version to 1.0.533 [skip ci]
8a820b6
decouple ignore-build-errors and disable-snap/tag-pipeline flags (#7727)
benjgil 2820435
fix(snap), import from original lane in case of fork and the lane is …
davidfirst 2a23d48
chore(e2e) - update react-env version in e2e tests (#7747)
GiladShoham d018f18
change(isolator) - do not install extensions dependencies (like envs)…
GiladShoham 7a1c760
feat: update selected packages by passing patterns to the update comm…
zkochan 02377a1
fix: don't relink local components in node_modules on repeat install …
zkochan bc516d4
Merge remote-tracking branch 'origin/master' into bit-link
zkochan 9e0d942
Merge remote-tracking branch 'origin/master' into bit-link
zkochan d8a6dc8
Merge branch 'master' into bit-link
zkochan 638d501
Merge remote-tracking branch 'origin/master' into bit-link
zkochan 7650882
fix: make changes suggested in PR comments
zkochan 4b2ae51
Merge remote-tracking branch 'origin/master' into bit-link
zkochan 48d6661
Merge branch 'master' into bit-link
GiladShoham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,10 +22,18 @@ function getAspectDirFromPath(id: string, pathsToResolveAspects?: string[]): str | |
return dirPath; | ||
} | ||
|
||
export function getAspectDir(id: string): string { | ||
export function getAspectDir(id: string, currentBitDir?: string | null): string { | ||
const aspectName = getCoreAspectName(id); | ||
let dirPath; | ||
|
||
if (currentBitDir) { | ||
dirPath = resolve(currentBitDir, 'node_modules/@teambit', aspectName); | ||
if (!existsSync(dirPath)) { | ||
throw new Error(`unable to find ${aspectName} in ${dirPath}`); | ||
} | ||
return dirPath; | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zkochan why not just pass the |
||
try { | ||
dirPath = getAspectDirFromPath(id); | ||
} catch (err: any) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we need to handle this also in some places of
load-bit.ts
for example we have there
getMainAspect
which later used to link the@teambit/bit
itself. which I think will now point to the wrong location.you can also look on
linkBit
in this file, and see if you get the correct location or not in action.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you are right. May I just update the getAspectDir to alway prefer reading from currentBitDir? Is there any scenario where currentBitDir should not be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zkochan yes you can change the
getAspectDir