Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tag-from-scope), pass metadata from previous build to the deploy pipeline #7874

Merged
merged 71 commits into from
Sep 6, 2023
Merged

fix(tag-from-scope), pass metadata from previous build to the deploy pipeline #7874

merged 71 commits into from
Sep 6, 2023

Conversation

davidfirst
Copy link
Member

@davidfirst davidfirst commented Sep 6, 2023 •
edited
Loading

  • fix some typos (done by @ranm8 ).
  • change the _metadata used by application aspect to metadata so then data such as publicDir is saved into the Version object.
  • in the deploy-task of application aspect, in case of tag-from-scope, which the build tasks instances are unavailable, use the metadata from the Version object.

ranm8 and others added 30 commits May 3, 2023 16:41
@ranm8
initial commit
7a835bd
@GiladShoham
Merge branch 'master' into static-single-install
e41d7f7
@GiladShoham
Merge branch 'master' into static-single-install
86384d0
@GiladShoham
load env's deps correctly for components even when node_modules are e…
ee360fc 
…mpty
@GiladShoham
Merge branch 'master' into static-single-install
94a52ea 
# Conflicts:
#	scopes/workspace/workspace/workspace-aspects-loader.ts
@GiladShoham
add env package to the env root dir
4906e77
@GiladShoham
Merge branch 'master' into static-single-install
190aca3
@GiladShoham
restore some code
a44cf99
@GiladShoham
load envs from root folders
9a87763
@GiladShoham
Merge branch 'master' into static-single-install
7b35cda
@GiladShoham
fixes for envs loading
76b31c0
@GiladShoham
do not add missing packages that are resolved from component from the…
8ad819d 
… root policy to the component manifest
@GiladShoham
fixes for calc dev vs runtime missing deps into the install manifest
a9ff7ec
@GiladShoham
more fixes for calc where to load envs from
e357d9e
@GiladShoham
fix check if dependencies changes as part of the install process
7c82d48
@GiladShoham
fix calculate env id for old components
53336bb
@GiladShoham
add p-locate package
ad47672
@GiladShoham
fix env id calculation - take env.jsonc into account when searching f…
9ee7dd6 
…or a valid env
@GiladShoham
fix for hasEnvManifest
6a2cfb5
@GiladShoham
fixes for calc missing deps into the install manifest when they are a…
d95a71e 
…lready a peer deps
@GiladShoham
fix calc of missing deps into the manifest for install
4d4a7a1
@GiladShoham
fix resolve aspects for workspace comps
3f1b45f
@GiladShoham
fix calc of getRuntimeModulePath
9ebeeab
@GiladShoham
only load aspects from the graph in case the root aspect is not a plugin
d86aaea
@GiladShoham
more fixes for envs loading
cb1c334
@GiladShoham
improve calc env id for core envs
343362d
@GiladShoham
show non loaded envs for bit envs command
c9e2cfe 
stop using ink for bit envs
@GiladShoham
show real env for bit show (and not loaded indication)
880b3d6
@GiladShoham
add issue in bit status for failed loading env
356b940
@GiladShoham
Merge branch 'master' into static-single-install
0cc990a
ranm8 and others added 19 commits June 11, 2023 14:03
@ranm8
Merge branch 'master' of github.com:teambit/bit
1229720
@ranm8
Merge branch 'master' of github.com:teambit/bit
7ed26db
@ranm8
Merge branch 'master' of github.com:teambit/bit
aac5954
@ranm8
Merge branch 'master' of github.com:teambit/bit
eaaf49a
@ranm8
Merge branch 'master' of github.com:teambit/bit
333043a
@ranm8
Merge branch 'master' of github.com:teambit/bit
da6eeaa
@ranm8
Merge branch 'master' of github.com:teambit/bit
4d70927
@ranm8
Merge branch 'master' of github.com:teambit/bit
91f28de
@ranm8
Merge branch 'master' of github.com:teambit/bit
bda1ae4
@ranm8
Merge branch 'master' of github.com:teambit/bit
c8048c9
@ranm8
Merge branch 'master' of github.com:teambit/bit
71327c0
@ranm8
testing typos
90fc1ae
@ranm8
Merge branch 'master' of github.com:teambit/bit
8a8358e
@ranm8
Merge branch 'master' of github.com:teambit/bit into typos
6843286
@ranm8
fix
ae9299e
@davidfirst
fix pnpm lock conflicts
0c57914
@davidfirst
fix(tag-from-scope), pass metadata from previous build to the deploy …
1c18539 
…pipeline
@davidfirst
Merge branch 'master' into typos
79f5e65
@davidfirst
add deprecation tag
5785f3b
GiladShoham
GiladShoham requested changes Sep 6, 2023
View reviewed changes
scopes/harmony/application/app-build-result.ts Outdated Show resolved Hide resolved
scopes/harmony/application/deploy.task.ts Show resolved Hide resolved
scopes/harmony/application/deploy.task.ts Outdated Show resolved Hide resolved
scopes/react/react/apps/web/compute-results.ts Outdated Show resolved Hide resolved
GiladShoham
GiladShoham previously approved these changes Sep 6, 2023
View reviewed changes
@davidfirst davidfirst merged commit 0aec359 into master Sep 6, 2023
@davidfirst davidfirst deleted the typos branch September 6, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidfirst @GiladShoham @ranm8