feature(install) - auto install envs that are configured in the generator aspect in workspace.jsonc #8151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator aspect in workspace.jsonc
guysaar223
approved these changes
Nov 15, 2023
zkochan
reviewed
Nov 15, 2023
Comment on lines
+457
to
+460
| const comps = await this.workspace.importAndGetMany( | ||
| [parsedId], | ||
| `to get the env ${parsedId.toString()} for installation` | ||
| ); |
There was a problem hiding this comment.
It seems to me that it would make more sense to loop over all envIdStr first and then pass the array of envIdStr to importAndGetMany, then do the next actions.
There was a problem hiding this comment.
you are right, but since this is usually a very small array it doesn't worth the complication of the code fmo
There was a problem hiding this comment.
@GiladShoham , if you don't want to refactor to do it one import, at least change this to run serially, not in parallel. It's risky to run import of multiple components in parallel. (we never do that). You could end up writing the same files at the same time and corrupt the objects.
The best would be of course to have one import.
Co-authored-by: Zoltan Kochan <z@kochan.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes