improvement(scope-rename), support renaming exported components #8456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ambit/bit into support-rename-scope-exported
GiladShoham
approved these changes
Jan 26, 2024
davidfirst
added a commit
that referenced
this pull request
Jan 30, 2024
This is a regression caused by #8456. When renaming a component with a namespace it was emitting the namespace, which resulted in ComponentNotFound error. Also, it was loading the components after the rename before changing their env in case the env was renamed as well. Both issues are fixed in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
bit scope renamesupports only new components. For exported, it suggests users to runbit renameone by one, which can be an hassle.This PR combines the logic from "rename", "renameScope" and "renameOwner" to one place "renameMultiple" and allows renaming multiple components, some can be exported, some can be new.
Previously, some of the actions during the rename were done only on "rename" or only on "renameScope", now all of them are aligned.