fix(import), do not remove the local env config in component.json #9319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the component.json of a component is written and the env is set to a local one, it gets removed upon
bit import
unexpectedly.After a long debugging, it turned out that the culprit was the aspect-merger. In order to remove multiple envs, it mutated the original
ExtensionData
of the scope component and deleted the env from there.This PR fixes it by cloning the entry before modifying it.
(for future reference - use
Proxy
to catch this issues, specifically thedeleteProperty
method of the Proxy).