Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've played with the rust server and modified a few things. My opinion is that there are too many choices:
I'd suggest we use
mono, 16000, i16
for the app and do not offer options to change them.And on rust server we can always resample up to 48000 stereo.
Btw this pull request is just a fix for my device. I'm using 48000, mono, i16 on the app, and 48000, stereo, i16 for the rust server, and my audio device is 48000, stereo, f32.
Didn't see any issue with data order or formats. And yes UDP is super fast.
@wiiznokes