Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(quickstart): Refs #16 -- Fix broken link #116

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

ChillarAnand
Copy link
Contributor

No description provided.

@kingdonb
Copy link
Member

kingdonb commented Apr 3, 2020

Thanks @ChillarAnand

The issue with some of our internal links is somewhat more complicated, I had to take a close look, we need to overhaul the docs site. You will find a lot of apparently broken links that are actually a problem with the way we have manipulated the original docs site from Deis upstream so that it does not coexist with a home page or live in /workflow/docs – you will also find the mobile version of the sidebar does not work in some cases where the full-width version does.

However I took a look at the page where this link lives, and adjacent links that do work, I think this change is correct and can be merged for the next release of workflow and docs. Thank you!

@Cryptophobia Cryptophobia self-requested a review April 3, 2020 19:30
@Cryptophobia
Copy link
Member

Thank you for fixing this link @ChillarAnand !

@Cryptophobia Cryptophobia merged commit a5bfa9f into teamhephy:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants