fix: add id to tool groups (#1636)

teamkeel · Oct 17, 2024 · e49abb9 · e49abb9
1 parent a0c5c8e
commit e49abb9
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 11 deletions.
diff --git a/tools/generator.go b/tools/generator.go
@@ -301,6 +301,7 @@ func (g *Generator) generateEmbeddedActionLinks() {
 					displayOrder++
 					// embed the tool as a tool group
 					tool.Config.EmbeddedTools = append(tool.Config.EmbeddedTools, &toolsproto.ToolGroup{
+						Id:           f.Name,
 						Title:        &toolsproto.StringTemplate{Template: f.Name}, // e.g. `orderItems` on a getOrder action
 						DisplayOrder: int32(displayOrder),
 						Tools: []*toolsproto.ToolGroup_GroupActionLink{

diff --git a/tools/proto/tools.pb.go b/tools/proto/tools.pb.go
diff --git a/tools/proto/tools.proto b/tools/proto/tools.proto
@@ -230,13 +230,17 @@ message ToolGroup {
 		// this embed group
 		repeated ResponseOverrides response_overrides = 2;
 	}
+
+	// A reference that persists for this tool group from build to build
+	string id = 1;
+
 	// Title of the group
-	StringTemplate title = 1;
+	StringTemplate title = 2;
 
-	int32 display_order = 2;
+	int32 display_order = 3;
 
 	// A list of decorated ActionLinks which will be embedded within this group
-	repeated GroupActionLink tools = 3;
+	repeated GroupActionLink tools = 4;
 }
 
 message ResponseOverrides {

diff --git a/tools/testdata/blog/tools.json b/tools/testdata/blog/tools.json
@@ -543,6 +543,7 @@
       "createEntryAction": { "toolId": "createPost" },
       "embeddedTools": [
         {
+          "id": "comments",
           "title": { "template": "comments" },
           "displayOrder": 1,
           "tools": [

diff --git a/tools/testdata/one_to_many_links/tools.json b/tools/testdata/one_to_many_links/tools.json
@@ -79,6 +79,7 @@
       ],
       "embeddedTools": [
         {
+          "id": "items",
           "title": { "template": "items" },
           "displayOrder": 1,
           "tools": [