fix: js database connection timeout and serverless driver #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davenewza
commented
Aug 24, 2024
•
davenewza
commented
- Ditching the neon-kysely dialect for the neon/serverless client
- Connection timeout value based on KEEL_DB_CONN_TIMEOUT or set to 45s
- Monkey patching the serverless client for our tracing needs
- Log the pg/neon dialect and timeout in db spans
chore: only destroy if neon fix: flexi db conn suspend timeout fix: if env doesnt exist
davenewza
force-pushed
the
neon-serverless-client
branch
from
4880b8f
to
929d762
Compare
davenewza
changed the title
davenewza
added a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.