fix: areabrick detection #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdreesen
force-pushed
the
fix-areabrick-detection
branch
from
2addb22
to
7187a55
Compare
jdreesen
force-pushed
the
fix-areabrick-detection
branch
from
7187a55
to
fb34ed0
Compare
The way of checking if a page had certain areabricks was too imprecise. It only checked if the brick identifier was in the `data` column of the `documents_editables` table. However, if the identifier is searched for without a delimiter, it will erroneously be found as a substring in longer identifiers (for example, “buttons” and “shortcut-buttons”). Therefore, we should only check whether the identifier occurs exactly as a type of an areablock.
jdreesen
force-pushed
the
fix-areabrick-detection
branch
from
fb34ed0
to
a7b1ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way of checking if a page had certain areabricks was too imprecise. It only checked if the brick identifier was somewhere in the
datacolumn of thedocuments_editablestable.However, if the identifier is searched for without a delimiter, it will erroneously be found as a substring in longer identifiers (for example, “buttons” and “shortcut-buttons”).
We should also limit the search to editables of type
areablock, as other editables can have any data that may also contain the identifier (for example, aninputeditable that contains CSS such as “buttons buttons--blue”).Therefore, we should only check whether the identifier occurs exactly as a type of an areablock.