Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TNTSearchTest::testSearchBoolean #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JosephLees
Copy link
Contributor

removed the space that was added to the lex in 6b4c2c7

@ViliusS
Copy link
Contributor

ViliusS commented Nov 22, 2020

This space was added because of issues when searching words containing hyphens. Also, IMHO it is a more appropriate definition of boolean search operator.

@JosephLees
Copy link
Contributor Author

JosephLees commented Nov 23, 2020

@ViliusS Was that issue around booleanSearch or just normal search? Currently in the testing for booleanSearch any search term that contains a hyphen is simply returning all the ids. I can continue to look into this issue while including the spaces in the boolean search operator if thats the way it should be formatted

@ViliusS
Copy link
Contributor

ViliusS commented Nov 23, 2020

Check the links in the commit message itself. It was an issue when using boolean search. Adding space allows for more complex searches, for example "item1 -2020-04" would return all item1 results excluding creation date of April.

Said that, I don't think that the test is broken. What is broken is the boolean search algorithm itself. For me it also returns all the ids almost all of the time. I'm still trying to find out what change broke it, but didn't had enough time to do this. It would be great if you could look into it. First suspect on my list is this change f2df690.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants