Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snap() and read() - using page to mean webpage does not work [fixed] #52

Closed
kensoh opened this issue Sep 2, 2019 · 1 comment
Closed

snap() and read() - using page to mean webpage does not work [fixed] #52

kensoh opened this issue Sep 2, 2019 · 1 comment
Labels
bug

Comments

@kensoh
Copy link
Member

kensoh commented Sep 2, 2019

There is a bug where using 'page' as the identifier to mean the entire webpage will trigger below error message. The tests for Yahoo website and DuckDuckGo did not pick this up because there are elements on both webpages that match the page identifier string.

[TAGUI][ERROR] - cannot find page

Raising this issue to commit a bugfix for the affected functions snap() and read().
@kensoh kensoh changed the title snap() and read() - using page to mean entire webpage does not work snap() and read() - using page to mean webpage does not work Sep 2, 2019
@kensoh kensoh added the bug label Sep 2, 2019
kensoh added a commit that referenced this issue Sep 2, 2019
@kensoh
#36 #50 #52 - added frame() & popup(), fixed snap() & read()
5a4040f 
#36 - add link to license in tagui.py to facilitate air-gap deployments (without internet access to pip)

# 50 - add frame() function to access web page frames (supports main frame and sub frame). add popup() function to access webpage popup tabs launched from webpage.

#52 - bugfix for snap() and read(), when 'page' is used to mean entire webpage a 'cannot find page' error message appears.
@kensoh
Copy link
Member Author

kensoh commented Sep 2, 2019

Bugfix implemented in v1.11 and available with pip install tagui --upgrade.

Now snapping screenshots of the webpage, and reading HTML text of the webpage work.

@kensoh kensoh changed the title snap() and read() - using page to mean webpage does not work snap() and read() - using page to mean webpage does not work [fixed] Sep 2, 2019
kensoh added a commit that referenced this issue Sep 2, 2019
@kensoh
#36 #50 #52 - added frame() & popup(), fixed snap() & read()
f26e536 
oops, missed out 1 line when pushing previous commit. somehow that line in snap() wasn't selected to push.

---

#36 - add link to license in tagui.py to facilitate air-gap deployments (without internet access to pip)

#50 - add frame() function to access web page frames (supports main frame and sub frame). add popup() function to access webpage popup tabs launched from webpage.

#52 - bugfix for snap() and read(), when 'page' is used to mean entire webpage a 'cannot find page' error message appears.
@kensoh kensoh closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kensoh