Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve disabled dropdown-link colour contrast #26

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

camillef
Copy link

@camillef camillef commented Sep 13, 2022

To obey https://dequeuniversity.com/rules/axe/4.4/color-contrast our links must have sufficient colour contrast.
Disabled dropdown links are currently failing a11y checks, as they use $gray-500 on a white background.
This PR updates the colour to $gray-700 which has sufficient contrast.

Before

image

After

image

@camillef camillef changed the title fix: improve disabled link colour contrast fix: improve disabled dropdown-link colour contrast Sep 13, 2022
@danielmatthew
Copy link
Contributor

Don't worry about the CircleCI status!

@camillef camillef merged commit 493950d into main Sep 13, 2022
@camillef camillef deleted the improve-disabled-link-color-contrast branch September 13, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants