-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Completed-By Column To Google Spreadsheets #15
base: dev
Are you sure you want to change the base?
Conversation
… the individual is logged in the Spreadsheet in Column C and D respectively.
Turned format date into arrow function. Updated package-lock.json
@zapdos26 how was this code tested? |
I literally ran the bot in a slack workspace and setup example values in a spreadsheet. Is there something more I should do? |
Nope, I was just wondering. For a feature like this where we're initially doing a PR to dev, a quick note about prior testing would be appreciated. I trust the code wasn't just written willy-nilly haha |
Ok |
Split up line 66.
Removed null from array, to prevent posting of null chores
…e/chorebot into add-completed-by � Conflicts: � utilities/getChores.js
I thought we had discussed not merging it. I actually mentioned this to @zapdos26 because I feel out-of-the-loop regarding this particular feature. |
Since that discussion, I find a possible reason to add it. |
@ddbruce I'm currently working on implementing chore completion in headsup, and having even a completed column would be quite useful. I'd be happy to re-implement or make the required changes so this could possibly be merged. |
@CKegel sounds good. What do you need from us? |
Ideally we could merge this branch, and then I'd add to it, so that when chores are sent to headsup, it includes the completed by data. Additionally the chore data would be sent to headsup whenever a chore is completed. |
Adds #14 for both usernames and userids
Along with that, it fixes an error regarding how map() is not a function of getChores()