Added async/await to fix firefox issue + other things #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbruce
requested changes
Jan 16, 2020
Renamed postServer to postToServer; Prevent notes from being empty; Removed window reload upon adding note/call; Added form reset on adding a note/call; Added refresh of notes on adding a call; Added await to getNotes in deleteCall(); Added </div> that was missing in the admin.html Currently the reset of the addCall causes the validator to run (this occurs even with reloading the page). This will need to be looked into for FireFox.
zapdos26
changed the title
ddbruce
requested changes
Jan 17, 2020
|
Code Climate has analyzed commit 7f6cf1e and detected 0 issues on this pull request. View more on Code Climate. |
ddbruce
approved these changes
Jan 17, 2020
|
Fixes #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Firefox issue of not adding calls/notes.
Prevent notes from being empty;
Removed window reload upon adding note/call;
Added form reset on adding a note/call;
Added refresh of notes on adding a call;
Added await to getNotes in deleteCall();
Added
</div>that was missing in the admin.htmlCurrently the reset of the addCall causes the validator to run (this occurs even with reloading the page). This will need to be looked into for Firefox.