Update sumObjects to coerce numeric strings, preserve Arrays in return
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e369f8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
techniq
requested changes
Apr 5, 2024
There was a problem hiding this comment.
Thanks @brandonmcconnell. Could you run pnpm format to fix the lint issues (prettier formatting) which will allow the CI tests to run, and add a few more tests...
- Using the accessor as a function (ex.
sumObjects(data, d => ...)) - Using the accessor as a string (ex.
sumObjects(data, 'value'))- data:
[{ foo: { value: 123 }, bar: { value: 234 } }, { foo: { value: 987 }, ... }]
- data:
- Data as an array of arrays
Thanks!
| const result = rollup( | ||
| items.flatMap((x) => entries(x ?? {})), | ||
| (values) => sum(values, (d) => { | ||
| const value = Number(getProp(d[1])); |
There was a problem hiding this comment.
I wonder if this should also get the key as the second argument (d[0] and maybe the whole object as the third (d), similar to just-map-values
techniq
approved these changes
May 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed made
sumObjectsto automatically coerce numeric strings to numberssumObjectsto return the summed values as an Array if all processed items are arrays